cccs-tom commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r693109767
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
What I meant was that, if you modify the example in the way I wrote it
in my reply, you would get the exact same YAML output as if I made the changes
you requested.
My intent was to allow maximum flexibility. As far as I know, this
implementation allows 100% of the `volumes` and `volumeMounts` spec. Could you
provide an example of something that isn't supported with this implementation
to help me better understand, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
