cccs-tom commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r693098848
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
I agree. So using the example you linked to, that would turn into:
```yaml
extraVolumes:
volumeName:
emptyDir: {}
extraVolumeMounts:
volumeName:
mountPath: "/opt/user/dir/mount"
```
The syntax is a little different, but I believe the flexibility is the same,
is it not? With the added bonus that additional volumes can be appended without
overriding the entire list (as per the use case I laid out in my previous
reply).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
