craig-rueda commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r693049758
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
Makes total sense. I just think that most folks will run into a spot
where they need an extra option for the volume, and will need to add a PR to
get the additional config they need shoved in.
Something like this is what I was thinking:
https://github.com/Kong/charts/blob/main/charts/kong/values.yaml#L35
It really allows for the most flexibility possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
