cccs-tom commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r692968489
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
Are you suggesting changing this to a `list` instead of a `map`? The
reason I implemented it this way is that my team manages multiple clusters
(with one deployment of Superset per cluster). It is useful to have one "base
configuration" with common values, which can then be appended to in the more
specific values. Making this a list would force us to repeat this part of our
configuration in multiple locations, which I was trying to avoid.
Having said that, I'm open to changing it. I'm just trying to better
understand your comment:
> That would allow users to customize extra volume options, etc.
With the way I implemented it, users are indeed free to specify whatever
options they require. I've added a few extra options to the examples I
committed in response to your previous comment. The only potential issue I can
think of is that the volume names are slightly restricted by what Helm
considers a valid key. Everything else will be used as-is by this line (85):
```yaml
{{- tpl (toYaml $volume) $ | nindent 10 -}}
```
Am I misunderstanding your comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
