craig-rueda commented on a change in pull request #16361:
URL: https://github.com/apache/superset/pull/16361#discussion_r693103654
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
Actually, it would look like:
```yaml
extraVolumes:
- name: "cool-volume"
emptyDir: {}
extraVolumeMounts:
- name: "cool-volume"
mountPath: "/opt/user/dir/mount"
```
This allows us to add things like `defaultMode`, etc. to the volume
definitions. We can also mount from secrets, or configMaps without changing
this chart.
##########
File path: helm/superset/templates/init-job.yaml
##########
@@ -76,5 +80,9 @@ spec:
configMap:
name: {{ template "superset.fullname" . }}-extra-config
{{- end }}
+ {{- range $volumeName, $volume := .Values.extraVolumes }}
Review comment:
Actually, it would look like:
```yaml
extraVolumes:
- name: "cool-volume"
emptyDir: {}
extraVolumeMounts:
- name: "cool-volume"
mountPath: "/opt/user/dir/mount"
```
This allows us to add things like `defaultMode`, etc. to the volume
definitions. We can also mount from secrets, or configMaps without changing
this chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
