kgabryje commented on PR #20353: URL: https://github.com/apache/superset/pull/20353#issuecomment-1155214645
Love the change with color picker! A few comments: 1. Maybe it would look better if we left the checkbox without any validation errors? If we changed copy in the tooltip to sth like "Ignored when '=' operator is selected", maybe that would be sufficient and we could simply ignore the state of the checkbox? 2. Is it possible to make the color picker popover a bit wider, so that the input fields for rgb values are wide enough to hold 3 digits? See video https://user-images.githubusercontent.com/15073128/173593263-468b7f69-b74e-4cd7-9f0d-39a4fb67676a.mov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
