[GitHub] [superset] stevetracvc commented on a diff in pull request #20353: feat(ConditionalFormatting): allow inverse color scaling

Mon, 13 Jun 2022 11:46:57 -0700 


stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r896030063


##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
     expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
   });
 
+  // it('getColorFunction EQUAL inverse', () => {

Review Comment:
   And what do you think of this instead?
   
![base_color](https://user-images.githubusercontent.com/70416691/173423221-ae44d6fb-7111-4a19-801c-a9bbbab2f79a.png)
   
   Date picker, and it respects the alpha chosen as the max alpha. Pretty sure 
the date picker broke all of the tests though, so I'll have to fix that to push
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to