stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r896846270
##########
superset-frontend/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx:
##########
@@ -208,14 +238,26 @@ export const FormattingPopoverContent = ({
<Select ariaLabel={t('Select column')} options={columns} />
</FormItem>
</Col>
- <Col span={12}>
+ <Col span={5}>
<FormItem
name="colorScheme"
- label={t('Color scheme')}
+ label={t('Base Color')}
rules={rulesRequired}
initialValue={colorScheme[0].value}
>
- <Select ariaLabel={t('Color scheme')} options={colorScheme} />
+ <ColorPickerControl />
+ </FormItem>
+ </Col>
+ <Col span={7}>
+ <FormItem
+ name="inverseScale"
+ label={t('Inverse Scale')}
+ rules={rulesInverseScale}
+ validateTrigger="onChange"
+ trigger="onChange"
+ tooltip="Invert the color alpha scale. Not valid with the equals
operator."
Review Comment:
good catch, thanks. Do you like the wording?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
