[GitHub] [superset] stevetracvc commented on a diff in pull request #20353: feat(ConditionalFormatting): allow inverse color scaling

Mon, 13 Jun 2022 09:06:59 -0700 


stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r895895238


##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
     expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
   });
 
+  // it('getColorFunction EQUAL inverse', () => {

Review Comment:
   These are the existing validation errors
   
![between_error_1](https://user-images.githubusercontent.com/70416691/173390982-91dc2ae6-18c7-4af5-bf53-063c3e0d0f1a.png)
   
![between_error_2](https://user-images.githubusercontent.com/70416691/173390994-8bbb188c-b9e3-45fc-834f-919ae8e9ba6e.png)
   
   This is what the inverse validation does (doesn't actually highlight 
checkbox in red, just gives the error)
   
![inverse_error](https://user-images.githubusercontent.com/70416691/173391009-8e430712-3234-423c-8bc9-059de7b03592.png)
   
   I don't know how to disable it. Disabled isn't a valid property on this 
component, and I can't find any other superset code that uses this Checkbox 
component (why is that?). Looks like control panels use the CheckboxControl 
from src/explore/components/controls/CheckboxControl, but that's a jsx file so 
I figured the Checkbox.tsx was the one you're moving toward...?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to