villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030606337
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/transformProps.ts:
##########
@@ -38,6 +41,7 @@ export default function transformProps(chartProps:
BigNumberTotalChartProps) {
timeFormat,
yAxisFormat,
} = formData;
+ const refs: Refs = {};
Review Comment:
the `refs` object is needed here so the downstream code (`transformProps` ->
Chart plugin component -> `Echart` component) can add the reference to the
chart div for the tooltip positioning callback to calculate the current
location of the pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]