villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030607808
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -311,7 +291,7 @@ class BigNumberVis extends
React.PureComponent<BigNumberVisProps> {
return (
<div className={className} style={{ height }}>
{this.renderFallbackWarning()}
- {this.renderKicker(kickerFontSize * height)}
+ {this.renderKicker((kickerFontSize || 0) * height)}
Review Comment:
lots of minor checks that needed to be added when the interfaces/types where
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
