villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030611775
##########
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/types.ts:
##########
@@ -80,10 +80,11 @@ export const DEFAULT_FORM_DATA:
Partial<EchartsGaugeFormData> = {
};
export interface EchartsGaugeChartProps
- extends ChartProps<EchartsGaugeFormData> {
+ extends BaseChartProps<EchartsGaugeFormData> {
formData: EchartsGaugeFormData;
- queriesData: ChartDataResponseResult[];
}
export type GaugeChartTransformedProps =
- EChartTransformedProps<EchartsGaugeFormData>;
+ BaseTransformedProps<EchartsGaugeFormData> &
+ ContextMenuTransformedProps &
+ CrossFilterTransformedProps;
Review Comment:
I decided to split out the context menu and cross filtering props into
separate types to avoid code duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
