villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030620696
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx:
##########
@@ -48,9 +48,12 @@ export default function EchartsTimeseries({
onContextMenu,
xValueFormatter,
xAxis,
+ refs,
}: TimeseriesChartTransformedProps) {
const { emitFilter, stack } = formData;
const echartRef = useRef<EchartsHandler | null>(null);
+ // eslint-disable-next-line no-param-reassign
+ refs.echartRef = echartRef;
Review Comment:
It was previously being passed to the `Echart` component in a separate
dedicated `ref` field. To avoid having two properties (one for the div ref and
one for the echart ref), I decided to just place both of them in that `refs`
object (I was becoming tired at this point and running low on imagination 😄 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
