villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030613923
##########
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx:
##########
@@ -106,6 +111,7 @@ function Echart(
// did mount
useEffect(() => {
handleSizeChange({ width, height });
+ return () => chartRef.current?.dispose();
Review Comment:
This fixes the sticky tooltip bug (disposes the chart instance during
cleanup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
