villebro commented on code in PR #22082:
URL: https://github.com/apache/superset/pull/22082#discussion_r1030610155
##########
superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/types.ts:
##########
@@ -16,20 +16,22 @@
* specific language governing permissions and limitations
* under the License.
*/
+import { QueryFormData } from '@superset-ui/core';
import {
- ChartDataResponseResult,
- ChartProps,
- QueryFormData,
-} from '@superset-ui/core';
-import { EchartsTitleFormData, EChartTransformedProps } from '../types';
+ BaseChartProps,
+ BaseTransformedProps,
+ ContextMenuTransformedProps,
+ CrossFilterTransformedProps,
+ TitleFormData,
+} from '../types';
import { DEFAULT_TITLE_FORM_DATA } from '../constants';
export type BoxPlotQueryFormData = QueryFormData & {
numberFormat?: string;
whiskerOptions?: BoxPlotFormDataWhiskerOptions;
xTickLayout?: BoxPlotFormXTickLayout;
emitFilter: boolean;
-} & EchartsTitleFormData;
+} & TitleFormData;
Review Comment:
I decided to remove the `Echarts` prefix from some types as it felt slightly
redundant (this is an ECharts plugin, after all)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
