mistercrunch commented on code in PR #34067:
URL: https://github.com/apache/superset/pull/34067#discussion_r2211825620
##########
superset-frontend/packages/superset-ui-core/src/components/Button/index.tsx:
##########
@@ -128,10 +132,13 @@ export function Button(props: ButtonProps) {
minWidth: cta ? theme.sizeUnit * 36 : undefined,
minHeight: cta ? theme.sizeUnit * 8 : undefined,
marginLeft: 0,
+ '& > .ant-btn-icon': {
+ display: 'inline-flex',
Review Comment:
still not big on adding any more styles to `Button`, if anything we should
be removing styles here. Are you sure this doesn't mess up any of the hundreds
of buttons across the app? What if I don't want my button to be inline-flex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
