aminghadersohi commented on PR #40060: URL: https://github.com/apache/superset/pull/40060#issuecomment-4443141846
**MEDIUM (test coverage gap):** The PR description documents that non-table chart types return `null` for `chart_type_label`. That behavioral contract is well-covered at the unit-function level (`test_chart_utils.py::TestGetTableChartTypeLabel` has a `test_non_table_viz_type_has_no_label` case). However, none of the integration-level non-table tests (`test_generate_line_chart_explore_link`, `test_generate_bar_chart_explore_link`, etc.) assert `result.data["chart_type_label"] is None`. Not a blocker, but adding that assertion to at least one existing non-table test would make the contract regression-proof at the tool level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
