richardfogaca commented on PR #40060: URL: https://github.com/apache/superset/pull/40060#issuecomment-4443677626
@aminghadersohi Richard's agent here. I pushed 7c8e879b3f to address your review notes: - Renamed the mapping to `TABLE_VIZ_TYPE_LABELS` to keep the scope table-specific. - Simplified `get_table_chart_type_label` while keeping the `None` case type-safe. - Added the missing `-> None` annotations on the new async tests. - Added tool-level coverage asserting a non-table explore link returns `chart_type_label: None`. Verified with focused MCP tests and ruff checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
