aminghadersohi commented on code in PR #40060:
URL: https://github.com/apache/superset/pull/40060#discussion_r3235858871
##########
tests/unit_tests/mcp_service/explore/tool/test_generate_explore_link.py:
##########
@@ -197,8 +198,36 @@ async def test_generate_table_explore_link_with_features(
result.data["url"]
==
"http://localhost:9001/explore/?form_data_key=comprehensive_key_456";
)
+ assert result.data["chart_type_label"] == "table chart"
mock_create_form_data.assert_called_once()
+ @patch("superset.daos.dataset.DatasetDAO.find_by_id")
+ @patch(
+
"superset.mcp_service.commands.create_form_data.MCPCreateFormDataCommand.run"
+ )
+ @pytest.mark.asyncio
+ async def test_generate_ag_grid_table_explore_link_label(
Review Comment:
**NIT:** Missing `-> None` return type annotation. Same as the other new
test above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
