rusackas commented on code in PR #42009:
URL: https://github.com/apache/superset/pull/42009#discussion_r3578666023
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx:
##########
@@ -32,6 +33,7 @@ export const FilterConfigurationLink: FC<FCBProps> = ({
<div
{...getFilterBarTestId('create-filter')}
onClick={onClick}
+ onKeyDown={handleKeyboardActivation(onClick)}
Review Comment:
Good catch — `onClick` is optional but the keyboard path called it
unconditionally. Fixed to guard it the same way the other callers in this file
already do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
