rusackas commented on code in PR #42009:
URL: https://github.com/apache/superset/pull/42009#discussion_r3578671490
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -255,6 +256,7 @@ const ViewModeToggle = ({
e.currentTarget.blur();
setMode('card');
}}
+ onKeyDown={handleKeyboardActivation(() => setMode('card'))}
Review Comment:
Added a test that exercises the keyboard path on the view-mode toggle
buttons (Enter/Space) and asserts the resulting view switches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
