rusackas commented on code in PR #42009:
URL: https://github.com/apache/superset/pull/42009#discussion_r3578669220
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -1760,6 +1761,7 @@ function DatasourceEditor({
role="button"
tabIndex={0}
onClick={onChangeEditMode}
+ onKeyDown={handleKeyboardActivation(onChangeEditMode)}
Review Comment:
Right, this affects every caller of `handleKeyboardActivation`, not just
this one. Fixed at the source: it now ignores auto-repeat keydowns, with a
regression test.
##########
superset-frontend/src/features/datasets/AddDataset/DatasetPanel/DatasetPanel.tsx:
##########
@@ -235,6 +236,11 @@ const renderExistingDatasetAlert = (dataset?:
DatasetObject) => (
openInNewTab(stripAppRoot(dataset.explore_url));
}
}}
+ onKeyDown={handleKeyboardActivation(() => {
+ if (dataset?.explore_url) {
+ openInNewTab(stripAppRoot(dataset.explore_url));
+ }
+ })}
Review Comment:
Done — extracted to `openExplore`, shared by both handlers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
