rusackas commented on code in PR #42009:
URL: https://github.com/apache/superset/pull/42009#discussion_r3580579511
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/CustomHeader.tsx:
##########
@@ -247,7 +266,13 @@ const CustomHeader: React.FC<CustomHeaderParams> = ({
isOpen={isMenuVisible}
onClose={() => setMenuVisible(false)}
>
- <div className="three-dots-menu" onClick={handleMenuClick}>
+ <div
+ role="button"
+ tabIndex={0}
+ className="three-dots-menu"
+ onClick={handleMenuClick}
+ onKeyDown={handleKeyboardActivation(handleMenuClick)}
Review Comment:
Already handled — `handleKeyboardActivation` ignores `event.repeat`, so a
held Enter/Space fires the callback once, not on every repeat.
##########
superset-frontend/packages/superset-ui-core/src/utils/handleKeyboardActivation.ts:
##########
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { KeyboardEvent } from 'react';
+
+/**
+ * Builds an `onKeyDown` handler that invokes `callback` when the user presses
+ * Enter or Space, mirroring a click for keyboard users. Pair it with an
+ * element's `onClick` so `role="button"` (or similar) controls are operable
+ * from the keyboard, satisfying `jsx-a11y/click-events-have-key-events`.
+ *
+ * <div role="button" onClick={handleClick}
+ * onKeyDown={handleKeyboardActivation(handleClick)} />
+ */
+export function handleKeyboardActivation(
+ callback: (event: KeyboardEvent) => void,
+) {
+ return (event: KeyboardEvent) => {
+ if (event.key === 'Enter' || event.key === ' ') {
+ // Prevent the page from scrolling on Space and stop any duplicate
+ // default activation on Enter.
+ event.preventDefault();
+ callback(event);
Review Comment:
Same as the other key-repeat thread — `handleKeyboardActivation` already
bails out on `event.repeat`, so this one's covered too.
##########
superset-frontend/packages/superset-ui-core/src/components/ModalTrigger/index.tsx:
##########
@@ -126,7 +127,13 @@ export const ModalTrigger = forwardRef(
</Button>
)}
{!isButton && (
- <div data-test="span-modal-trigger" onClick={open} role="button">
+ <div
+ data-test="span-modal-trigger"
+ onClick={open}
+ onKeyDown={handleKeyboardActivation(open)}
+ role="button"
+ tabIndex={0}
+ >
Review Comment:
That div + `span-modal-trigger` mismatch predates this PR — this diff only
adds keyboard handling, not the span-to-div change. Renaming the test id
touches call sites in several unrelated test files, so leaving it out of scope
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
