bito-code-review[bot] commented on code in PR #42009:
URL: https://github.com/apache/superset/pull/42009#discussion_r3578672537
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -255,6 +256,7 @@ const ViewModeToggle = ({
e.currentTarget.blur();
setMode('card');
}}
+ onKeyDown={handleKeyboardActivation(() => setMode('card'))}
Review Comment:
<!-- Bito Reply -->
The suggestion to add keyboard accessibility tests is appropriate. Since the
pull request introduces new keyboard event handlers using
`handleKeyboardActivation` to improve accessibility, verifying these paths with
tests ensures the functionality works as expected and prevents regressions.
Adding a test case that simulates Enter/Space key events and asserts the
expected state change is a standard best practice for maintaining accessibility
features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
