AliMahmoudDev commented on PR #42009: URL: https://github.com/apache/superset/pull/42009#issuecomment-4971359984
This is a solid a11y fix. Would it also be worth adding `aria-atomic="true"` to the updated region? That way the screen reader reads the entire region rather than just the diff, which is clearer for users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
