sha174n commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5641727751
@rusackas Follow-up in ff60f7e: 8e2cb12 broke five `validate_test.py` cases that mock `create_engine`, since the hook then tried to register a listener against a MagicMock. Those now stub the hook, and the guard raises instead of logging and continuing when the driver handle is unreachable, so it can't quietly hand back a connection the limit was never applied to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
