sha174n commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5642443160
@rusackas The `validate_parameters` gap you flagged is covered in 8e2cb12 (replied above). One more cleanup in 57860c6: the guard checked the inner driver handle but the error message named the outer wrapper, so it now names both, and `test_database_engine_disables_attach` goes through the public `get_sqla_engine()` context manager instead of the private helper, which pins the real construction path. Unit tests and pre-commit pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
