sha174n commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5663099447
@rusackas Cleanup-only in 38a9b92, no behavior change: trimmed the hook docstrings, added a note on why the shillelagh dialects cannot carry an `on_connect` of their own the way `SupersetAPSWDialect` does, and folded the two register-then-attach tests into one parametrized case. Pre-commit and the unit tests pass locally. Two things I looked at and deliberately left alone, flagging in case you disagree: `metricflow://` is also an APSW shillelagh dialect but has no engine spec here, so it lands on `BaseEngineSpec` and skips the hook. Giving it one means adding a user-visible engine spec, which felt like a separate call than this PR. Same for `superset/cli/test_db.py`, which builds its own engine for an operator-supplied URI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
