sha174n commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5661824400
@rusackas Cleanup-only follow-up in 1e9d659, no behavior change: the connect-listener params now use the real SQLAlchemy types instead of `Any`, `apsw` is imported lazily so it stays off the startup import chain, and the comment/docstring are trimmed. Also dropped the `register_engine_events` patches those tests carried. The driver gate from 9bfdc0d already no-ops on a mocked engine, so they were dead, and `validate_test.py` is back to matching master. One test added for the meta database, which inherits this spec and reports an `apsw` dialect while declaring a different driver name, so it's covered but nothing pinned that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
