rusackas commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5648812125
Good catch, and a real one, my fail-closed suggestion would have broken `shillelagh+sqlglot`/`multicorn2` on every connect. Verified both directions myself: with the old unconditional registration, connecting to `shillelagh+sqlglot://` does throw `TypeError: Expected an APSW connection on SQLGlotConnection, got NoneType`; gating on `engine.dialect.driver == "apsw"` fixes it, and `SELECT 1` runs fine again. Also checked shillelagh's own entry points, `sqlglot`/`multicorn2` really do report their own driver names distinct from `apsw`, so the gate is exactly right, not just accidentally right for the one case you tested. Still LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
