sha174n commented on PR #43991: URL: https://github.com/apache/superset/pull/43991#issuecomment-5648083150
@rusackas Follow-up in 9bfdc0d: the hook was registering for every `shillelagh` backend, but shillelagh also ships non-APSW dialects (`shillelagh+sqlglot`, `shillelagh+multicorn2`) that land on this spec via the backend-only fallback in `get_engine_spec`. Those have no APSW handle, so they hit the fail-closed branch on every connect. Now gated on `engine.dialect.driver == "apsw"`, which covers `gsheets://` and `superset://` too, with a test pinning that the sqlglot backend still connects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
