aminghadersohi commented on PR #44685: URL: https://github.com/apache/superset/pull/44685#issuecomment-5902630634
Reviewed the full diff at 1eecb6c99a8b34105dff2f56ef4455a7ed974e0f: no new correctness, cross-engine regression, or test-coverage findings. The Oracle mappings precede the unchanged base mappings, and stored dataset types pick up the corrected classification without a metadata re-sync. Rechecked EnxDev’s September 29 review body and inline thread: the LONG → Text/STRING request is addressed in 1eecb6c9, with upper/lowercase regression cases and documentation; the thread is resolved. No outstanding asks or additional commits. Validation: Oracle + base-engine unit tests — 158 passed (using the local superset-core/src on PYTHONPATH). All applicable pre-commit hooks passed on the three PR files, including mypy and pylint. No live Oracle integration test was run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
