aminghadersohi commented on PR #44685:
URL: https://github.com/apache/superset/pull/44685#issuecomment-5902868743
### Acceptance at 1eecb6c99a8b34105dff2f56ef4455a7ed974e0f
- **PASS — demonstrate user-visible impact.** Ran a throwaway
`gvenzl/oracle-free:23-slim` container (server reports Oracle Free 23.26.3),
using SQLAlchemy 2.0.52 and Superset's `create_app()` → `Database` →
`SqlaTable.fetch_metadata()`, then persisted/reloaded the dataset. Observed:
| Reflected/stored type | Generic type | Classification |
|---|---|---|
| `NUMBER`, `NUMBER(19, 0)`, `NUMBER(10, 2)` | NUMERIC (0) |
`is_numeric=True` |
| `BINARY_FLOAT`, `BINARY_DOUBLE` | NUMERIC (0) | `is_numeric=True` |
| `FLOAT` → `DOUBLE PRECISION`; `INTEGER` | NUMERIC (0) |
`is_numeric=True` |
| `CLOB`, `NCLOB`, `LONG`, `VARCHAR(40 CHAR)` | STRING (1) |
`is_string=True` |
| `DATE`, `TIMESTAMP`, `TIMESTAMP WITH TIME ZONE` | TEMPORAL (2) |
`is_temporal=True` |
| `BLOB`, `RAW(16)` | null | none of those classifications |
All **16 column cases passed**; Oracle `SUM(ns)=10.25`. With Oracle
mappings disabled as a control, NUMBER/BINARY_* and CLOB/NCLOB lose their
generic types, and LONG incorrectly becomes numeric. `num_cols` changes from
FLOAT/INTEGER/LONG to the seven actual numeric columns above.
The actual reflected metadata also passed metric-default and rendered
folder-drop dispatcher checks: numeric → SUM; string/temporal → COUNT_DISTINCT;
binary/untyped → skipped. **57 Jest tests passed**, including 34 live-metadata
acceptance cases (jsdom, not browser pointer-drag E2E).
- **PASS — upstream mappings and regression coverage.** Oracle unit suite:
**45 passed**. All applicable pre-commit hooks passed on the three
branch-changed files, including mypy. No fix or push needed. Conditional
downstream 6.1 carry remains a separate, unconfirmed release requirement.
- **PASS — conditional disposition.** Impact was reproduced, so the “no
impact / expected behavior” closure path does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
