bito-code-review[bot] commented on PR #44835: URL: https://github.com/apache/superset/pull/44835#issuecomment-5935800657
<!-- Bito Reply --> The proposed approach aligns with the metadata contract introduced in this PR. The contract specifies that for opted-in providers, the `MetadataRefreshAdapter` is bound to a store, and discovery operations—including `get_runtime_schema()`—must use that bound instance to ensure consistency with the refreshed snapshot. Using the bound adapter's `get_runtime_schema()` instead of the legacy classmethod is the correct way to avoid stale or empty runtime choices, as the legacy path does not participate in the bound store's lifecycle. The PR already includes a unit test file, `tests/unit_tests/semantic_layers/metadata_contract_test.py`, which is designed to verify these obligations, including explicit shared deadlines and error handling in an isolated environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
