mikebridge commented on code in PR #44835:
URL: https://github.com/apache/superset/pull/44835#discussion_r4159903425
##########
superset/semantic_layers/models.py:
##########
@@ -257,9 +259,18 @@ def after_delete(
security_manager.semantic_layer_after_delete(mapper, connection,
target)
- @cached_property
+ @property
def implementation(
self,
+ ) -> SemanticLayerABC[Any, SemanticViewABC]:
+ if metadata_binding.participates(self):
+ # Read authorization belongs to callers with full request context.
+ return metadata_binding.layer_implementation(self)
Review Comment:
Addressed in 74a604376434379748549c4d7f6e3857e4deedd4: participating layers
use the bound adapter for runtime schema. The endpoint regression first
returned the legacy schema, then passed with refreshed choices. Denied callers
do not construct a provider or backend. The API layer retains its typed error
responses when this is merged forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
