sadpandajoe commented on code in PR #44835:
URL: https://github.com/apache/superset/pull/44835#discussion_r4157879333
##########
superset/semantic_layers/models.py:
##########
@@ -257,9 +259,18 @@ def after_delete(
security_manager.semantic_layer_after_delete(mapper, connection,
target)
- @cached_property
+ @property
def implementation(
self,
+ ) -> SemanticLayerABC[Any, SemanticViewABC]:
+ if metadata_binding.participates(self):
+ # Read authorization belongs to callers with full request context.
+ return metadata_binding.layer_implementation(self)
Review Comment:
For an opted-in stored layer, `/schema/runtime` still calls the provider's
legacy classmethod rather than the bound adapter, so it can return stale or
empty runtime choices while view discovery uses the refreshed snapshot. Could
that endpoint use the bound adapter's `get_runtime_schema()` for participating
layers, with an endpoint-level test asserting the refreshed choices?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
