mikebridge commented on code in PR #44835:
URL: https://github.com/apache/superset/pull/44835#discussion_r4162261921
##########
superset/semantic_layers/models.py:
##########
@@ -700,7 +718,18 @@ def data_for_slices(self, slices: list[Any]) ->
ExplorableData:
return self.data
def get_extra_cache_keys(self, query_obj: QueryObjectDict) ->
list[Hashable]:
- return []
+ token: str | None = self.metadata_cache_token
+ return [token] if token is not None else []
Review Comment:
The API layer already maps these errors at chart-data GET/POST, keeping
transport policy out of cache-key construction. Coverage in `2740673693`
(pushed to #44849) exercises both GET and POST through the real
ChartDataCommand/QueryContext/SemanticView.get_extra_cache_keys path and
confirms unavailable/deadline/configuration failures return 503/504/422.
Removing only the GET mapper makes all three GET cases fail; the mapper was
restored. The missing datasource/Explore HTTP mappings, including column
values, are fixed in that commit. No model-level swallowing or fallback cache
key was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
