bito-code-review[bot] commented on code in PR #44835:
URL: https://github.com/apache/superset/pull/44835#discussion_r4162015745
##########
superset/semantic_layers/models.py:
##########
@@ -257,9 +259,18 @@ def after_delete(
security_manager.semantic_layer_after_delete(mapper, connection,
target)
- @cached_property
+ @property
def implementation(
self,
+ ) -> SemanticLayerABC[Any, SemanticViewABC]:
+ if metadata_binding.participates(self):
Review Comment:
<!-- Bito Reply -->
The suggestion to cache the configuration parse per operation is valid and
appropriate. The change from `@cached_property` to a standard `@property`
causes the `json.loads` and registry lookup to execute on every access, which
can negatively impact performance when multiple property accesses occur within
a single query cache-key computation. Applying the suggestion to cache the
parsed configuration per operation will mitigate this overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
