mikebridge commented on PR #44835: URL: https://github.com/apache/superset/pull/44835#issuecomment-6007836921
@fitzee thanks for the thorough review; all six items are addressed at the new head (store 25d516c46f, with the stack merged forward through #44849/#44851). On item 1, we are keeping rotation after natural expiry because identical discovered fields do not prove unchanged metric definitions. The preserved `test_same_name_and_discovery_after_refresh_cannot_reuse_old_query_result` regression changes the result from 17 to 23 under identical discovery and requires a fresh cache identity. Commit b4a07b86bb adds `SEMANTIC_LAYER_METADATA_SNAPSHOT_TTL_SECONDS`, default 300 seconds, for both catalog snapshots and compatibility generations, so operators can trade metadata freshness for longer chart-cache reuse; commit 25d516c46f also prevents publication delay from extending that lifetime. Provider-supplied definition revisions, which would make reuse provably safe, are a planned follow-up. The other fixes are in 9aed7aafd7 (failed totals and Sentinel cleanup), 9c963e57a9 (annotation capture, decimal failures and verification of the view's token against the store), and fe90082b68 on #44834 (the contract now states discovery must be identical for every user of the connection). Redis connection/envelope load and thumbnail/screenshot coverage remain recorded follow-ups before enablement. Joe's new TLS-shutdown thread will get its own follow-up commit on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
