Latest webrev looks good...thanks! -renee
On Fri, Aug 28, 2009 at 11:54:04AM -0700, Michael Hunter wrote: > On Fri, 28 Aug 2009 10:58:28 -0700 > Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote: > > > On Fri, Aug 28, 2009 at 09:45:33AM -0700, Michael Hunter wrote: > > > On Thu, 27 Aug 2009 19:27:16 -0700 > > > Michael Hunter <michael.hunter at sun.com> wrote: > > > > > > [...] > > > > New webrev (and I'll probably have another one tomorrow morning with a > > > > few more things in it esp. a fix for a problem I see with IPv4 static > > > > addresses). > > > [...] > > > > > > New webrev up. Has updated comment for XXX, seb-099, and fix for > > > static addresses didn't work without a refresh. > > > > ncp.c, lines 547-550: Minor wordsmithing on the comment for > > nwamd_ncp_deactivate_priority_group_all(); I would suggest > > > > This function deactivates all priority groups at level 'priority' > > and lower (which is, numerically, all priorities >= priority). > > ACCEPT > > > > > ncu.h: does nwamd_plumb_unplumb_interface() still need to be in here? > > It should only be called via the two wrappers you added, right? > > removed, in ncu.c made static > > > > > ncu_ip.c, line 591: any special reason this is a syslog() call and > > not nlog()? > > That message shouldn't be there nor the line next to it. Both removed. > > > > > ncu_phys.c: woohoo, no more XXX!! Special thanks to Alan for jumping > > in on that one while on vacation. > > Definitely! > > New webrev up. > > I will update bugs after my lunch. > > mph > > > > > -renee
