>> 688-702 duplicates what follows in 722-738.
>>     
>
> Those lines don't even look close to me.  On the next webrev give me
> the line numbers and starting/ending line contents so I can match them
> up.
>   
The line numbers are from the webrev dated "Monday, August 31, 2009 
3:13:39 AM PDT"

ncu_ip.c 683-725 is what I am questioning.

If dhcp is requested, the state moves to online; otherwise the state is 
changed to offline, uninitialized. Then we move to online, up in 732 no 
matter what we did in 683-725.

line 692: "Restore network/location if it is in maintenance state"

line 700: s/refresh/restore/

>   
>> at 714, is a "return;" missing? otherwise the state changes to online/up 
>> in 722.
>>     
>
> This one also.
>
>   
This is in the "else" section of the above code block (683-725)

Anurag

Reply via email to