On Mon, 31 Aug 2009 09:51:21 -0400
"Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
>
> >> 688-702 duplicates what follows in 722-738.
> >>
> >
> > Those lines don't even look close to me. On the next webrev give me
> > the line numbers and starting/ending line contents so I can match them
> > up.
> >
> The line numbers are from the webrev dated "Monday, August 31, 2009
> 3:13:39 AM PDT"
>
> ncu_ip.c 683-725 is what I am questioning.
>
> If dhcp is requested, the state moves to online; otherwise the state is
> changed to offline, uninitialized. Then we move to online, up in 732 no
> matter what we did in 683-725.
ACCEPT (removed the first instance)
>
> line 692: "Restore network/location if it is in maintenance state"
ACCEPT
>
> line 700: s/refresh/restore/
ACCEPT
>
> >
> >> at 714, is a "return;" missing? otherwise the state changes to online/up
> >> in 722.
> >>
> >
> > This one also.
> >
> >
> This is in the "else" section of the above code block (683-725)
ACCEPT (used a goto instead of duplicating common exit code)
Michael
>
> Anurag
>
