Michael Hunter wrote:
> /net/coupe.eng/builds/mph/nwam1_work/webrev
>
apologies if comments overlap with those of Renee.
libnwam_event.c
these are the only place in the library that write to syslog(), right?
is this ok, done in other libraries?
ncu.c
211, 212: why don't you wrap these two lines around "if
(ncu->ncu_node.u_if.ipv{4,6})"? and then add
"ncu->ncu_node.u_if.{dhcp,stateful,stateless}_configured = B_FALSE" to
the appropriate clauses.
224-227, 233-239: these lines are redundant like your comment says.
might be better to remove it completely so that we aren't wondering
what's going on in the future
211-240 could be written as:
if (ncu->ncu_node.u_if.ipv4) {
unplumb;
dhcp=false;
plumb;
}
if (ncu->ncu_node.u_if.ipv6) {
unplumb;
stateless=false;
stateful=false;
plumb;
}
458-463: can be rewritten as above to avoid unnecessary calls to unplumb.
ncu_phys.c
1841-1849: doesn't nwamd_ncp_activate_priority_group() bring the start
the state machine for this NCU?
ncu_ip.c
387-383: We shouldn't log error if smf_restore_instance() fails. If the
service isn't it maintenance, smf_restore_instance returns non-success.
I've seen noise from this in the current builds.
866-868: I think we should check to make sure that the NCU is not
already online. Can cause multiple online/up state event being sent to
listeners.
860, 955: XXX ?
I am getting some ideas for 11103 going through these changes.
Anurag
