> While I agree that this is a good show case I don't like the copy paste > approach. While this is simple and cheap now, we keep underestimating the > hidden costs of code duplications.
I understand the concern here Michael. But then I am not sure on the best way forward. It has mostly jsp and couple of classes. The class would need to be adapted to work with Oak and we would also need to remove dependency on jackrabbit-core as it would not be possible to support both (due to conflicting lucene version). if you have any suggestion on how to structure it that would be helpful. If its not ok to put the sample here I can remove it but I do not see a simple way to structure it without copying > See e.g. the recent mess caused by the fact we copy pasted util.Text a couple > of years ago [1]. Yup saw that. However that should have caused the osgi-it to fail. Not sure why it did not failed. Chetan Mehrotra On Thu, Aug 6, 2015 at 3:15 PM, Michael Dürig <mdue...@apache.org> wrote: > > Hi Chetan, > > While I agree that this is a good show case I don't like the copy paste > approach. While this is simple and cheap now, we keep underestimating the > hidden costs of code duplications. > > See e.g. the recent mess caused by the fact we copy pasted util.Text a > couple of years ago [1]. This was the simplest thing to do then and probably > only took a couple of minutes. Now, years later it costed us a couple of man > days as at least Julian, Angela, Alex and myself got involved/blocked with > this. If the release wouldn't have had other issues it would have resulted > in a broken release on top of that... Another couple of man weeks given the > calamities this would have caused for upstream projects. > > Michael > > [1] http://markmail.org/message/cmr5zl6f74hgjoqs > > > On 5.8.15 5:53 , Chetan Mehrotra wrote: >> >> Hi Team, >> >> Currently we do not have good example around how to run Oak properly >> in standalone environment. One of the good example is >> jackrabbit-webapp [1] module which serve as a blueprint for any user >> on how to embed Oak. Currently this module only enables running Oak >> with Segment store and that to with most basic setup. >> >> I would like to modify this module to use oak-pojorsr [2] to configure >> complete Oak stack as we do it in Sling. For that I would like to copy >> this module to oak under oak-webapp and then refactor it to run >> complete Oak stack. >> >> Thoughts? >> >> Chetan Mehrotra >> [1] https://github.com/apache/jackrabbit/tree/trunk/jackrabbit-webapp >> [2] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-pojosr >> >
