[
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623704#comment-13623704
]
Michael Dürig commented on OAK-709:
-----------------------------------
I'm generally fine with applying the "work in progress" patch OAK-709_4.patch.
Just a few minor points:
* Shouldn't {{RootImpl.getQueryEngine}} be based on the secure node? Same with
{{RootImpl.getIndexProvider}}. Not sure though.
* Let's add an issue reference to this issue in the FIXME in
{{RootImpl.getRootState}}
* Let's make the TODO in {{KernelNodeState#equals}} a FIXME. I really think
this is broken and we need to review/fix it.
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
> Key: OAK-709
> URL: https://issues.apache.org/jira/browse/OAK-709
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: angela
> Attachments:
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> OAK-709_2.patch, OAK-709_3.patch, OAK-709_4.patch, OAK-709-equals_hack.patch,
> OAK-709.patch, SecureNodeState.java
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
