On Mon, Aug 23, 2010 at 08:32:06PM +0200, Storm-Olsen Marius (Nokia-MS-Qt/Austin) wrote: > As many of you already know, the developers of Qt often use their own > in-house "pastebin" site called Codepaster, to do their code reviewing > if not one-on-one. However, in the spirit of Open Governance we want > to move this process into the public, and focus the usage on one solution. > well, my dream is a fully-integrated review/integration system. in that light, a quick review would be a submission like any other, only with a limited audience and no integration request attached:
$ ... hack hack hack ... $ git commit $ ... hack hack hack ... $ git commit $ git qt-push HEAD~2.. Review 12345 for tracking branch qt/4.7 created. https://review.qt.nokia.com/?id=12345 [ irc ... hey marius, blabla ] $ ... hack hack hack ... $ git commit --amend $ git qt-push -u 12345 and so on. each review request would have a set of attributes, like required reviewers, whether it is meant for integration, etc., all editable via a web form (and optionally qt-push would have an interactive mode to set the properties immediately, like our codepaster tool does). the review ui itself would look very much like reviewboard does (extended by the capability to review entire patch series). approving a review with an integration request would automatically add it to the cherry-pick queue for the CI system. integration results would update the request status. successful integration would close associated bug reports. i have lots of other details thought out, but i don't want to bore you now. ;) note that "trivial pastes" are simply out of scope, we can have a regular pastebin.qt.nokia.com for that based on dpaste or something like that. _______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
