On Fri, Aug 27, 2010 at 03:02:12AM +0200, Wuwon Kevin (Nokia-MS/Brisbane) wrote: > > ~> Syntax highlighting for C/C++, Javascript and Diffs (also Git > > ~> patches) > > You shouldn't have to look at diff files when you're reviewing code. > Ideally, > it'd show the revisions of the code before and after the change side by side > and > with the option of viewing more context as needed. Diff syntax adds clutter, > which makes it harder to spot the bugs. > i for one find side-by-side views much less readable than syntax-highlighted diffs (patience diff often being a big plus).
> > Should also handle > > ------------------ > > ~> Freetext searching > > Perhaps, but it might be a better idea to link the code review to the commit > that it resulted in (eg. the git SHA1). > this isn't a one-to-one relationship. > > ~> Responding to a patch based on the previous (avoid manual > > ~> copy'n'paste) > > If I understand you correctly, > i think you don't. what marius wants is complete adjustability and version control of the reviews themselves. anyone who seriously worked (or rather, tried to work) with gitorious knows why emphasizing that point is important. > this should be irrelevant if the command line tools are good enough. _______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
