On Monday, August 23, 2010, Marius Storm-Olsen wrote: > Gil Quim (Nokia-MS/MtView) said the following on 23.08.2010 13:50: > > On 08/23/2010 11:32 AM, Storm-Olsen Marius (Nokia-MS-Qt/Austin) wrote: > >> As many of you already know, the developers of Qt often use their own > >> in-house "pastebin" site called Codepaster, to do their code reviewing > >> if not one-on-one. However, in the spirit of Open Governance we want > >> to move this process into the public, and focus the usage on one > >> solution. > > > > Just forwarding fast feedback received at > > http://twitter.com/acruiz/status/21934588870 > > > > @quimgil Code review != pastebin. I would really encourage you to look > > at ReviewBoard for proper code reviews :-) > > > > http://www.reviewboard.org/ > > While I agree that Reviewboard is a fine tool, I think it might be a > bit too involved for the fast-pace code sharing and reviewing we tend > to do. It would be a better fit with handling the Merge Requests for > sure. But requiring personal accounts and signing in to do reviews, > quick checking of patches and just general IRC commenting, I feel it's > a tad too "involved", if you know what I mean.
i suppose it really comes down whether you want to do code review (which is what it sounds like from your email) or just really quick throw aways (which .. also sounds like it happens sometimes from your email :). with the postreview command line tool (something similar could be done with a QtCreator plugin), it's really quite fast. for random "here's 6 lines of code, what do you think" while gathered on irc, then a simple pastebin is ok. but for commenting, revisioning, etc.. i can only agree with Quim here and recommend reviewboard (or an improved merge request system on gitorious ala Oswald's suggestion) as "the way to go". it has inline threaded commenting, search, versioning, screenshot support, etc. setting a permissive default review group that goes to a /dev/null email makes publishing a review from the command line very quick: post-review -p --summary="very cool addition" we left behind pastebin for anything more than a random quick snippet a couple years ago and have never looked back. as for what reviewboard is _not_ good for, ime: * random bits of code not based on anything in the current repository * non-code things, e.g. "here's a backtrace" for these things a pastebin is much more convenient. Plasma Desktop even provides a nice pastbin widget with drag'n'drop and copy/paste support that makes those things ++quick, and we also use that tool for things reviewboard isn't great for. our use of reviewboard is more frequent than pastebin. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
