As others have said, as have I in the past, code review != pastebin. Below are the key differences on the concepts:
> ~> Syntax highlighting for C/C++, Javascript and Diffs (also Git > ~> patches) You shouldn't have to look at diff files when you're reviewing code. Ideally, it'd show the revisions of the code before and after the change side by side and with the option of viewing more context as needed. Diff syntax adds clutter, which makes it harder to spot the bugs. > Should also handle > ------------------ > ~> Freetext searching Perhaps, but it might be a better idea to link the code review to the commit that it resulted in (eg. the git SHA1). Of course, scripts invoked from the git command line should be able to generate these links. But I'd demote this to the "ideal" category. > ~> Responding to a patch based on the previous (avoid manual > ~> copy'n'paste) If I understand you correctly, this should be irrelevant if the command line tools are good enough. $ git codereview # hack hack hack $ git codereview # second revision of review, responding to comments # hack hack hack, etc. $ git push There shouldn't be a need to generate diffs, remember what you're diffing to what, etc. > Ideal > ----- > ~> Allow for commenting on individual lines of patch, inline This should be essential. How can you review if you can't comment? > (Yes, I know about Reviewboard and Google's > Rietveld. Not as "simple" as a pastebin/codepaster though, and > simplicity and efficiency is key for high usage.) What is the definition of "simple"? I'd say in this case, the two important points are: 1. Ease of submitting review requests: if it were easy as `git codereview`, that's much simpler than having to look up the correct SHA1s to diff. 2. Responsiveness of web interface: this is where reviewboard and gitorious do a disservice to the image of code review tools - I agree that their slowness is a little disruptive. But Rietveld/Gerrit are lightning quick. Kevin. _______________________________________________ Opengov mailing list Opengov@qt-labs.org http://lists.qt-labs.org/listinfo/opengov
