On Tue, 6 Oct 2026 15:05:19 GMT, Andy Goryachev <[email protected]> wrote:
>> Robert Lichtenberger has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264588: Stylisitic improvements.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java
> line 127:
>
>> 125:
>> 126: @Test
>> 127: @Disabled("JDK-8393470")
>
> oh, that's not what I meant - let's split this test in two, one with all the
> cases that pass with this PR (and may fail in the master), and one that
> contains the failing case(s). Add `@Disabled` to the failing one.
>
> This way we get the coverage for the fixed cases and get the test case ready
> for the followup.
I will do that. Note however, that some things that work now will work
differently, if we implement "the algorithm" (with the three character classes)
mentioned above, e.g. clicking on "123" in the "Bug #123" case will currently
select "#123" but only "123" if/after we change behaviour.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4203547526
